[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210402171832.GC5402@sirena.org.uk>
Date: Fri, 2 Apr 2021 18:18:32 +0100
From: Mark Brown <broonie@...nel.org>
To: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc: mazziesaccount@...il.com, Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-power@...rohmeurope.com, linux-arm-msm@...r.kernel.org,
linux-renesas-soc@...r.kernel.org
Subject: Re: [RFC PATCH v3 4/7] regulator: add property parsing and callbacks
to set protection limits
On Thu, Mar 11, 2021 at 12:23:02PM +0200, Matti Vaittinen wrote:
> + /*
> + * Existing logic does not warn if over_current_protection is given as
> + * a constraint but driver does not support that. I think we should
> + * warn about this type of issues as it is possible someone changes
The "existing logic" bit here is for a changelog, not the code - as soon
as the patch is applied the comment becomes inaccurate. This also seems
like a separate patch.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists