linux-kernel - Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210402174215.GI5402@sirena.org.uk>
Date:   Fri, 2 Apr 2021 18:42:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-power@...rohmeurope.com
Subject: Re: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators

On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote:

Acked-by: Mark Brown <broonie@...nel.org>

but...

> @@ -0,0 +1,676 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright 2014 Embest Technology Co. Ltd. Inc.

Please make the entire comment a C++ one so things look more
intentional.

> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>

A regulator driver generally shouldn't need machine interfaces...

> +				ret = regulator_enable_regmap(rdev);
> +			else
> +				ret = regulator_disable_regmap(rdev);
> +
> +			if (ret)
> +				dev_err(rdev_get_dev(rdev),
> +					"LED status error\n");

Better to print the error code, and that error message could be a bit
more descriptive.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)