linux-kernel - Re: [PATCH] firmware_loader: Remove unnecessary conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27640831-b996-93f0-4a4f-5b5d2ae24554@linuxfoundation.org>
Date:   Fri, 2 Apr 2021 16:24:35 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, shuah@...nel.org
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] firmware_loader: Remove unnecessary conversion to bool

On 2/18/21 2:12 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./tools/testing/selftests/firmware/fw_namespace.c:98:54-59: WARNING:
> conversion to bool not needed here.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   tools/testing/selftests/firmware/fw_namespace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/firmware/fw_namespace.c b/tools/testing/selftests/firmware/fw_namespace.c
> index 5ebc1ae..0e393cb 100644
> --- a/tools/testing/selftests/firmware/fw_namespace.c
> +++ b/tools/testing/selftests/firmware/fw_namespace.c
> @@ -95,7 +95,7 @@ static bool test_fw_in_ns(const char *fw_name, const char *sys_path, bool block_
>   		}
>   		if (block_fw_in_parent_ns)
>   			umount("/lib/firmware");
> -		return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;

This looks right to me. test_fw_in_ns() returns true or false and
test_fw_in_ns() callers print appropriate message.

I don't think this patch is necessary.

thanks,
-- Shuah