linux-kernel - Re: [PATCH v3 16/30] staging: rtl8723bs: tidy up some error handling in core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210403094247.GC1563@agape.jhs>
Date:   Sat, 3 Apr 2021 11:42:47 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     dan.carpenter@...cle.com
Cc:     gregkh@...uxfoundation.org, joe@...ches.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 16/30] staging: rtl8723bs: tidy up some error handling
 in core/rtw_mlme.c

On Sat, Apr 03, 2021 at 11:13:38AM +0200, Fabio Aiuto wrote:
> the RT_TRACE() output is not useful so we want to delete it. In this case
> there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've
> deleted the RT_TRACE() output and added a goto unlock to show
> that we can't continue if rtw_createbss_cmd() fails.
> 
> Suggested-by: David Carpenter <dan.carpenter@...cle.org>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)

Hi Dan,

I put a Suggested-by tag on one patch in v3 patchset. But reading the docs
on submitting patches I relaized later that maybe it requires your permission before.

It' written about Reviewed-by but not about Suggested-by, should I have asked you before, should I?

I'm sorry if I should have.

thank you,

fabio