linux-kernel - Re: [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if condition in core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb2db42b7e721e6fbeaf8324d33801b5a9bfc03a.camel@perches.com>
Date:   Sat, 03 Apr 2021 08:24:12 -0700
From:   Joe Perches <joe@...ches.com>
To:     Fabio Aiuto <fabioaiuto83@...il.com>, gregkh@...uxfoundation.org
Cc:     dan.carpenter@...cle.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if
 condition in core/rtw_recv.c

On Sat, 2021-04-03 at 11:13 +0200, Fabio Aiuto wrote:
> fix post-commit checkpatch issue:
> 
> CHECK: Using comparison to false is error prone
> 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381:
> +				if (psecuritypriv->
> 			bcheck_grpkey == false &&
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index cd4324a93275..21949925ec77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -378,7 +378,7 @@ static signed int recvframe_chkmic(struct adapter *adapter,  union recv_frame *p
>  
> 
>  			} else {
>  				/* mic checked ok */
> -				if (psecuritypriv->bcheck_grpkey == false &&
> +				if (!psecuritypriv->bcheck_grpkey &&
>  				    (IS_MCAST(prxattrib->ra) == true))
>  					psecuritypriv->bcheck_grpkey = true;
>  			}