linux-kernel - Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8955077a-94b6-9ffb-d2f6-b611845b6cfc@gmail.com>
Date:   Sun, 4 Apr 2021 00:30:41 +0300
From:   Ivan Safonov <insafonov@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Michael Straube <straube.linux@...il.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Peilin Ye <yepeilin.cs@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from
 OnAction()

On 4/2/21 4:04 PM, Greg Kroah-Hartman wrote:
> On Sun, Mar 28, 2021 at 07:33:25PM +0300, Ivan Safonov wrote:
>> on_action_spct() do nothing, because rtw_get_stainfo() has no side
>> effects. Other action handlers are trivial.
>>
>> Signed-off-by: Ivan Safonov <insafonov@...il.com>
> 
> Same here, wrong driver name :(
> 

Driver name is "r8188eu"...

$ grep 'r8188eu' drivers/staging/rtl8188eu/include/drv_types.h
#define DRV_NAME "r8188eu"

$ grep 'r8188eu' drivers/staging/rtl8188eu/os_dep/usb_intf.c -B1 -A7
static struct usb_driver rtl8188e_usb_drv = {
         .name = "r8188eu",
         .probe = rtw_drv_init,
         .disconnect = rtw_dev_remove,
         .id_table = rtw_usb_id_tbl,
         .suspend =  rtw_suspend,
         .resume = rtw_resume,
         .reset_resume = rtw_resume,
};

$ cat drivers/staging/rtl8188eu/Kconfig
# SPDX-License-Identifier: GPL-2.0
config R8188EU
         tristate "Realtek RTL8188EU Wireless LAN NIC driver"
         depends on WLAN && USB && CFG80211
         depends on m
         select WIRELESS_EXT
         select WEXT_PRIV
         select LIB80211
         select LIB80211_CRYPT_WEP
         select LIB80211_CRYPT_CCMP
         help
         This option adds the Realtek RTL8188EU USB device such as 
TP-Link TL-WN725N.
         If built as a module, it will be called r8188eu.

if R8188EU

config 88EU_AP_MODE
         bool "Realtek RTL8188EU AP mode"
         default y
         help
         This option enables Access Point mode. Unless you know that 
your system
         will never be used as an AP, or the target system has limited 
memory,
         "Y" should be selected.

endif