linux-kernel - Re: [PATCH v2 6/9] w1: ds2438: fixed a coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202104031127.r94NhBbq-lkp@intel.com>
Date:   Sat, 3 Apr 2021 11:16:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Luiz Sampaio <sampaio.ime@...il.com>, zbr@...emap.net
Cc:     kbuild-all@...ts.01.org, corbet@....net,
        rikard.falkeborn@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, Luiz Sampaio <sampaio.ime@...il.com>
Subject: Re: [PATCH v2 6/9] w1: ds2438: fixed a coding style issue

Hi Luiz,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc5 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luiz-Sampaio/w1-ds2438-adding-support-for-calibration-of-current-measurements/20210403-092618
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d93a0d43e3d0ba9e19387be4dae4a8d5b175a8d7
config: alpha-randconfig-r023-20210402 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6282c64dc6cf3656cc3a9034b04f22d2a655ad39
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luiz-Sampaio/w1-ds2438-adding-support-for-calibration-of-current-measurements/20210403-092618
        git checkout 6282c64dc6cf3656cc3a9034b04f22d2a655ad39
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/w1/slaves/w1_ds2438.c:391:40: error: macro "BIN_ATTR" requires 5 arguments, but only 4 given
     391 | static BIN_ATTR(iad, 0664, iad_write, 0);
         |                                        ^
   In file included from include/linux/kobject.h:20,
                    from include/linux/module.h:20,
                    from drivers/w1/slaves/w1_ds2438.c:9:
   include/linux/sysfs.h:219: note: macro "BIN_ATTR" defined here
     219 | #define BIN_ATTR(_name, _mode, _read, _write, _size)   \
         | 
>> drivers/w1/slaves/w1_ds2438.c:391:8: error: type defaults to 'int' in declaration of 'BIN_ATTR' [-Werror=implicit-int]
     391 | static BIN_ATTR(iad, 0664, iad_write, 0);
         |        ^~~~~~~~
>> drivers/w1/slaves/w1_ds2438.c:398:3: error: 'bin_attr_iad' undeclared here (not in a function); did you mean 'bin_attr_vad'?
     398 |  &bin_attr_iad,
         |   ^~~~~~~~~~~~
         |   bin_attr_vad
   drivers/w1/slaves/w1_ds2438.c:391:8: warning: 'BIN_ATTR' defined but not used [-Wunused-variable]
     391 | static BIN_ATTR(iad, 0664, iad_write, 0);
         |        ^~~~~~~~
   drivers/w1/slaves/w1_ds2438.c:277:16: warning: 'iad_read' defined but not used [-Wunused-function]
     277 | static ssize_t iad_read(struct file *filp, struct kobject *kobj,
         |                ^~~~~~~~
   drivers/w1/slaves/w1_ds2438.c:255:16: warning: 'iad_write' defined but not used [-Wunused-function]
     255 | static ssize_t iad_write(struct file *filp, struct kobject *kobj,
         |                ^~~~~~~~~
   cc1: some warnings being treated as errors


vim +/BIN_ATTR +391 drivers/w1/slaves/w1_ds2438.c

   390	
 > 391	static BIN_ATTR(iad, 0664, iad_write, 0);
   392	static BIN_ATTR_RO(page0, DS2438_PAGE_SIZE);
   393	static BIN_ATTR_RO(temperature, 0/* real length varies */);
   394	static BIN_ATTR_RO(vad, 0/* real length varies */);
   395	static BIN_ATTR_RO(vdd, 0/* real length varies */);
   396	
   397	static struct bin_attribute *w1_ds2438_bin_attrs[] = {
 > 398		&bin_attr_iad,
   399		&bin_attr_page0,
   400		&bin_attr_temperature,
   401		&bin_attr_vad,
   402		&bin_attr_vdd,
   403		NULL,
   404	};
   405	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30383 bytes)