linux-kernel - Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YGgeY4Q0MIvyx1FY@kroah.com>
Date:   Sat, 3 Apr 2021 09:50:59 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     dan.carpenter@...cle.com, joe@...ches.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in
 core/rtw_xmit.c

On Sat, Apr 03, 2021 at 09:48:06AM +0200, Fabio Aiuto wrote:
> On Sat, Apr 03, 2021 at 09:40:08AM +0200, Greg KH wrote:
> > On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote:
> > > remove all RT_TRACE logs
> > > 
> > 
> > I don't mean to be a pain, but this changelog text needs some work.
> > 
> > This says _what_ it does, but not _why_ you are doing this.  The kernel
> > documentation has a section on how to write a good changelog text, you
> > might want to look at that.
> 
> you are right, I spent time writing the cover, but not the changelog which
> will remain in kernel history

Take portions of what you write in the cover letter, into the changelog
for the patches.  Or the other way around is also good, depending on
which you write first :)

thanks,

greg k-h