[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 4 Apr 2021 22:12:13 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Colin King <colin.king@...onical.com>,
Zhang Rui <rui.zhang@...el.com>,
Amit Kucheria <amitk@...nel.org>,
Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] thermal/drivers/devfreq_cooling: Fix error return
if kasprintf returns NULL
Hi Colin,
On 25/03/2021 18:21, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently when kasprintf fails and returns NULL, the error return -ENOMEM
> is being assigned to cdev instead of err causing the return via the label
> remove_qos_re to return the incorrect error code. Fix this by explicitly
> setting err before taking the error return path.
>
> Addresses-Coverity: ("Unused valued")
> Fixes: f8d354e821b2 ("thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
Thanks for your patch. It was already fixed after being reported by
kbuild-test.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists