lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Apr 2021 03:58:16 +0300 From: Laurent Pinchart <laurent.pinchart@...asonboard.com> To: Douglas Anderson <dianders@...omium.org> Cc: Andrzej Hajda <a.hajda@...sung.com>, Neil Armstrong <narmstrong@...libre.com>, Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...l.net>, Sam Ravnborg <sam@...nborg.org>, Linus W <linus.walleij@...aro.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, robdclark@...omium.org, Stephen Boyd <swboyd@...omium.org>, Steev Klimaszewski <steev@...i.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, linux-arm-msm@...r.kernel.org, Stanislav Lisovskiy <stanislav.lisovskiy@...el.com>, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>, Robert Foss <robert.foss@...aro.org>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 05/12] drm/bridge: ti-sn65dsi86: Move drm_panel_unprepare() to post_disable() Hi Doug, Thank you for the patch. On Fri, Apr 02, 2021 at 03:28:39PM -0700, Douglas Anderson wrote: > We prepared the panel in pre_enable() so we should unprepare it in > post_disable() to match. > > This becomes important once we start using pre_enable() and > post_disable() to make sure things are powered on (and then off again) > when reading the EDID. > > Signed-off-by: Douglas Anderson <dianders@...omium.org> > Reviewed-by: Andrzej Hajda <a.hajda@...sung.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index c006678c9921..e30460002c48 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -452,8 +452,6 @@ static void ti_sn_bridge_disable(struct drm_bridge *bridge) > regmap_write(pdata->regmap, SN_ML_TX_MODE_REG, 0); > /* disable DP PLL */ > regmap_write(pdata->regmap, SN_PLL_ENABLE_REG, 0); > - > - drm_panel_unprepare(pdata->panel); > } > > static u32 ti_sn_bridge_get_dsi_freq(struct ti_sn_bridge *pdata) > @@ -869,6 +867,8 @@ static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > { > struct ti_sn_bridge *pdata = bridge_to_ti_sn_bridge(bridge); > > + drm_panel_unprepare(pdata->panel); > + > clk_disable_unprepare(pdata->refclk); > > pm_runtime_put_sync(pdata->dev); -- Regards, Laurent Pinchart
Powered by blists - more mailing lists