linux-kernel - Re: [PATCH] doc: Fix mistaken diagram references in RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210405002935.GD2696@paulmck-ThinkPad-P72>
Date:   Sun, 4 Apr 2021 17:29:35 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Frederic Weisbecker <frederic@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] doc: Fix mistaken diagram references in RCU

On Sun, Apr 04, 2021 at 11:58:43PM +0200, Frederic Weisbecker wrote:
> The 3 diagrams describing rcu_gp_init() all spuriously refer to the same
> figure, probably due to some copy/paste issue. Fix the references.
> 
> Signed-off-by: Frederic Weisbecker <frederic@...nel.org>

Good catch, queued, thank you!

							Thanx, Paul

> ---
>  .../RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> index 3f6ce41ee0c5..11cdab037bff 100644
> --- a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> +++ b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> @@ -339,14 +339,14 @@ The diagram below shows the path of ordering if the leftmost
>  leftmost ``rcu_node`` structure offlines its last CPU and if the next
>  ``rcu_node`` structure has no online CPUs).
>  
> -.. kernel-figure:: TreeRCU-gp-init-1.svg
> +.. kernel-figure:: TreeRCU-gp-init-2.svg
>  
>  The final ``rcu_gp_init()`` pass through the ``rcu_node`` tree traverses
>  breadth-first, setting each ``rcu_node`` structure's ``->gp_seq`` field
>  to the newly advanced value from the ``rcu_state`` structure, as shown
>  in the following diagram.
>  
> -.. kernel-figure:: TreeRCU-gp-init-1.svg
> +.. kernel-figure:: TreeRCU-gp-init-3.svg
>  
>  This change will also cause each CPU's next call to
>  ``__note_gp_changes()`` to notice that a new grace period has started,
> -- 
> 2.25.1
>