linux-kernel - Re: [PATCH v5 0/2] Introduce the BQ25790 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210405100253.qjf3u7u37lqh5mpt@earth.universe>
Date:   Mon, 5 Apr 2021 12:02:53 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Ricardo Rivera-Matos <r-rivera-matos@...com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmurphy@...com
Subject: Re: [PATCH v5 0/2] Introduce the BQ25790 charger driver

Hi,

On Mon, Feb 01, 2021 at 08:17:45PM -0600, Ricardo Rivera-Matos wrote:
> This patchset introduces the BQ25790 integrated buck-boost charging IC.

Please add changelogs compared to previous version to
your cover letters.

> Dan Murphy (2):
>   dt-bindings: power: Add the bq25790 dt bindings
>   power: supply: bq25790: Introduce the BQ25790 charger driver
> 
>  .../bindings/power/supply/bq25790.yaml        |   95 ++
>  drivers/power/supply/Kconfig                  |    8 +
>  drivers/power/supply/Makefile                 |    1 +
>  drivers/power/supply/bq25790_charger.c        | 1100 +++++++++++++++++
>  drivers/power/supply/bq25790_charger.h        |  148 +++
>  5 files changed, 1352 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/bq25790.yaml
>  create mode 100644 drivers/power/supply/bq25790_charger.c
>  create mode 100644 drivers/power/supply/bq25790_charger.h

FYI: I don't have further review notes and wait for a new version
with the things pointed out by Krzysztof being fixed. For cleanup
of usb_register_notifier you might want to check how you fixed the
same issue for bq256xx via bq256xx_charger_reset() or my ignored
comment in v4 patchset.

Thanks,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)