linux-kernel - RE: [EXT] [PATCH 2/2] qede: Use 'skb_add_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB338846FE9B4E083A7D7FD4C3AB779@DM6PR18MB3388.namprd18.prod.outlook.com>
Date:   Mon, 5 Apr 2021 10:07:26 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [EXT] [PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand
 coding it

> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Sent: Sunday, April 4, 2021 6:13 PM
> To: Ariel Elior <aelior@...vell.com>; GR-everest-linux-l2 <GR-everest-linux-
> l2@...vell.com>; davem@...emloft.net; kuba@...nel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
> janitors@...r.kernel.org; Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Subject: [EXT] [PATCH 2/2] qede: Use 'skb_add_rx_frag()' instead of hand coding
> it
> 
> External Email
> 
> ----------------------------------------------------------------------
> Some lines of code can be merged into an equivalent 'skb_add_rx_frag()'
> call which is less verbose.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/qlogic/qede/qede_fp.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index ee3e45e38cb7..8e150dd4f899 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1209,12 +1209,9 @@ static int qede_rx_build_jumbo(struct qede_dev
> *edev,
>  		dma_unmap_page(rxq->dev, bd->mapping,
>  			       PAGE_SIZE, DMA_FROM_DEVICE);
> 
> -		skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
> -				   bd->data, rxq->rx_headroom, cur_size);
> +		skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, bd->data,
> +				rxq->rx_headroom, cur_size, PAGE_SIZE);
> 
> -		skb->truesize += PAGE_SIZE;
> -		skb->data_len += cur_size;
> -		skb->len += cur_size;
>  		pkt_len -= cur_size;
>  	}
> 
> --
> 2.27.0

Thank you Christophe.
Acked-by: Manish Chopra <manishc@...vell.com>