linux-kernel - Re: [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Apr 2021 12:32:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Luiz Sampaio <sampaio.ime@...il.com>
Cc:     zbr@...emap.net, corbet@....net, rikard.falkeborn@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/9] w1: ds2438: adding support for calibration of
 current measurements

On Sat, Apr 03, 2021 at 01:45:47AM -0300, Luiz Sampaio wrote:
> The following patches aim to make a user able to calibrate the current measurement of the DS2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if the current is zero, for instance. This patch gives support for reading the page1 registers (including the offset register) and for writing to the offset register. The DS2438 datasheet shows a calibration routine, and with this patch, the user can do this quickly by writing the correct value to the offset register. This patch was tested on real hardware using a power supply and an electronic load.
> Please help to review this series of patches.
> 
> Best regards!
> Sampaio
> ---
> Changes in v3:
> - I accidentally added a wrong line that would not compile. I'm sorry. Fixed it.
> 
> Changes in v2:
> - Using git send-email to send the patches
> - Adding documentation as requested
> - Separating the coding style changes in different patches as requested
> 
> Luiz Sampaio (9):
>   w1: ds2438: fixed a coding style issue
>   w1: ds2438: fixed a coding style issue
>   w1: ds2438: fixed a coding style issue
>   w1: ds2438: fixed a coding style issue
>   w1: ds2438: fixed a coding style issue
>   w1: ds2438: fixed a coding style issue

You can not have different patches that do different things, yet have
identical subject lines.

Please make them unique.

thanks,

greg k-h