[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210405124557.pxkkpv3zxvkkengl@LuizSampaio-PC.localdomain>
Date: Mon, 5 Apr 2021 09:45:57 -0300
From: Luiz Sampaio <sampaio.ime@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: zbr@...emap.net, corbet@....net, rikard.falkeborn@...il.com,
gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/9] w1: ds2438: adding support for calibration of
current measurements
On Mon, Apr 05, 2021 at 12:53:38PM +0200, Greg KH wrote:
> On Mon, Apr 05, 2021 at 07:50:00AM -0300, Luiz Sampaio wrote:
> > The following patches aim to make a user able to calibrate the current measurement of the DS2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if the current is zero, for instance. This patch gives support for reading the page1 registers (including the offset register) and for writing to the offset register. The DS2438 datasheet shows a calibration routine, and with this patch, the user can do this quickly by writing the correct value to the offset register. This patch was tested on real hardware using a power supply and an electronic load.
> > Please help to review this series of patches.
>
> Please linewrap your text here :(
>
Hello! Thanks for the review! I'm sorry about this again, I did it for my patches but forgot the cover letter. Won't repeat!
Powered by blists - more mailing lists