linux-kernel - RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OSBPR01MB47735215095EF20C0B0AA793BA779@OSBPR01MB4773.jpnprd01.prod.outlook.com>
Date:   Mon, 5 Apr 2021 13:53:10 +0000
From:   Min Li <min.li.xe@...esas.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "derek.kiernan@...inx.com" <derek.kiernan@...inx.com>,
        "dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management
 Unit (SMU) support

> > >
> > > Any specific reason you are not using the misc_device api?  That
> > > would clean up this driver a lot, there's no need to create a whole
> > > class just for a single driver.
> > >
> >
> > Hi Greg
> >
> > No specific reason. I just didn't know the existence of misc_register API.
> 
> Your file is in drivers/misc/ :)
> 
> > Do you recommend using this API to create the device?
> 
> Yes.
> 
> > If yes, can you tell me how to obtain a appropriate MINOR number from
> > miscdevice.h?
> 
> No need to reserve one, we don't do that anymore, just ask for a dynamic
> value and the next availble one will be given to your driver automatically.
> 
> thanks,
> 
> greg k-h

Thanks, I will change to use misc_register and get back to you.

Thanks

Min