linux-kernel - Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Apr 2021 14:36:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xiaofei Tan <tanxiaofei@...wei.com>, gregkh@...uxfoundation.org,
        jirislaby@...nel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, linuxarm@...neuler.org,
        Xiaofei Tan <tanxiaofei@...wei.com>
Subject: Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent should use
 tabs

Hi Xiaofei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on v5.12-rc6 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-a004-20210405 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 2760a808b9916a2839513b7fd7314a464f52481e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/da18c35dce46cd938810b3ca12275fac9c97f64d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
        git checkout da18c35dce46cd938810b3ca12275fac9c97f64d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/tty/sysrq.c:558:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
                   return op_p;
                   ^
   drivers/tty/sysrq.c:555:2: note: previous statement is here
           if (i != -1)
           ^
   1 warning generated.


vim +/if +558 drivers/tty/sysrq.c

^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  545  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  546  /*
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  547   * get and put functions for the table, exposed to modules.
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  548   */
23cbedf812ff7c drivers/tty/sysrq.c  Emil Velikov    2020-05-13  549  static const struct sysrq_key_op *__sysrq_get_key_op(int key)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  550  {
23cbedf812ff7c drivers/tty/sysrq.c  Emil Velikov    2020-05-13  551  	const struct sysrq_key_op *op_p = NULL;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  552  	int i;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  553  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  554  	i = sysrq_key_table_key2index(key);
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  555  	if (i != -1)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  556  		op_p = sysrq_key_table[i];
97f5f0cd8cd0a0 drivers/char/sysrq.c Dmitry Torokhov 2010-03-21  557  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16 @558  		return op_p;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  559  }
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  560  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27615 bytes)