linux-kernel - Re: [PATCH v2 2/2] power: supply: bq25980: Move props from battery node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Apr 2021 18:11:09 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Ricardo Rivera-Matos <r-rivera-matos@...com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: bq25980: Move props from battery
 node

Hi,

On Thu, Feb 11, 2021 at 08:38:07AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Feb 10, 2021 at 04:56:46PM -0600, Ricardo Rivera-Matos wrote:
> > Currently POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and
> > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE are exposed on the battery node
> > and this is incorrect.
> > 
> > This patch exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT and
> > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE on the charger node rather
> > than the battery node.
> 
> Now it makes sense if you only formatted it in human-readable way.
> Please fix your git/editor/email client/desktop unless you used such
> formatting intentionally. If it was intentional, then please don't - do
> like everyone else in Linux kernel (git log will help).

Thanks, queued to the power-supply tree (I fixed up the broken
commit message).

-- Sebastian

> 
> Best regards,
> Krzysztof
> 
> > 
> > Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family")
> > Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@...com>
> > ---
> >  drivers/power/supply/bq25980_charger.c | 40 ++++++++------------------
> >  1 file changed, 12 insertions(+), 28 deletions(-)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)