linux-kernel - Re: [PATCH v6 4/8] mm,memory_hotplug: Allocate memmap from the added memory range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 01:10:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Linux Memory Management List <linux-mm@...ck.org>,
        David Hildenbrand <david@...hat.com>,
        Michal Hocko <mhocko@...nel.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Vlastimil Babka <vbabka@...e.cz>, linux-kernel@...r.kernel.org,
        Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v6 4/8] mm,memory_hotplug: Allocate memmap from the added
 memory range

Hi Oscar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on pm/linux-next tip/x86/core arm64/for-next/core linus/master v5.12-rc6]
[cannot apply to hnaz-linux-mm/master next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Oscar-Salvador/Allocate-memmap-from-hotadded-memory-per-device/20210406-191333
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 6e11b376fd74356e32d842be588e12dc9bf6e197
config: x86_64-randconfig-a015-20210406 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a46f59a747a7273cc439efaf3b4f98d8b63d2f20)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/4d4265dd4e598c7b0971d57894685136229f5d07
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Oscar-Salvador/Allocate-memmap-from-hotadded-memory-per-device/20210406-191333
        git checkout 4d4265dd4e598c7b0971d57894685136229f5d07
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/base/memory.c:201:3: error: implicit declaration of function 'vmemmap_deinit_space' [-Werror,-Wimplicit-function-declaration]
                   vmemmap_deinit_space(start_pfn, nr_vmemmap_pages);
                   ^
   drivers/base/memory.c:201:3: note: did you mean 'vmemmap_init_space'?
   include/linux/memory_hotplug.h:112:12: note: 'vmemmap_init_space' declared here
   extern int vmemmap_init_space(unsigned long pfn, unsigned long nr_pages,
              ^
   drivers/base/memory.c:231:4: error: implicit declaration of function 'vmemmap_deinit_space' [-Werror,-Wimplicit-function-declaration]
                           vmemmap_deinit_space(start_pfn, nr_pages);
                           ^
   2 errors generated.


vim +/vmemmap_deinit_space +201 drivers/base/memory.c

   171	
   172	static int memory_block_online(struct memory_block *mem)
   173	{
   174		unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr);
   175		unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
   176		unsigned long nr_vmemmap_pages = mem->nr_vmemmap_pages;
   177		int ret;
   178	
   179		/*
   180		 * Although vmemmap pages have a different lifecycle than the pages
   181		 * they describe (they remain until the memory is unplugged), doing
   182		 * its initialization and accounting at hot-{online,offline} stage
   183		 * simplifies things a lot
   184		 */
   185		if (nr_vmemmap_pages) {
   186			ret = vmemmap_init_space(start_pfn, nr_vmemmap_pages, mem->nid,
   187						 mem->online_type);
   188			if (ret)
   189				return ret;
   190		}
   191	
   192		ret = online_pages(start_pfn + nr_vmemmap_pages,
   193				   nr_pages - nr_vmemmap_pages, mem->online_type,
   194				   mem->nid);
   195	
   196		/*
   197		 * Undo the work if online_pages() fails.
   198		 */
   199		if (ret && nr_vmemmap_pages) {
   200			vmemmap_adjust_pages(start_pfn, -nr_vmemmap_pages);
 > 201			vmemmap_deinit_space(start_pfn, nr_vmemmap_pages);
   202		}
   203	
   204		return ret;
   205	}
   206	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (41796 bytes)