linux-kernel - Re: [PATCH 5.10 004/126] ext4: shrink race window in ext4_should_retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Apr 2021 17:11:26 -0400
From:   Eric Whitney <enwlinux@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Eric Whitney <enwlinux@...il.com>,
        Theodore Tso <tytso@....edu>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 004/126] ext4: shrink race window in
 ext4_should_retry_alloc()

* Pavel Machek <pavel@....cz>:
> Hi!
> 
> > From: Eric Whitney <enwlinux@...il.com>
> 
> > A per filesystem percpu counter exported via sysfs is added to allow
> > users or developers to track the number of times the retry limit is
> > exceeded without resorting to debugging methods.  This should provide
> > some insight into worst case retry behavior.
> 
> This adds new counter exported via sysfs, but no documentation of that
> counter...
> 
> Best regards,
> 								Pavel
> 

Thanks for the observation.  I'll check with Ted to see what he'd like.

Eric


> > @@ -257,6 +259,7 @@ static struct attribute *ext4_attrs[] = {
> >  	ATTR_LIST(session_write_kbytes),
> >  	ATTR_LIST(lifetime_write_kbytes),
> >  	ATTR_LIST(reserved_clusters),
> > +	ATTR_LIST(sra_exceeded_retry_limit),
> >  	ATTR_LIST(inode_readahead_blks),
> >  	ATTR_LIST(inode_goal),
> >  	ATTR_LIST(mb_stats),
> 
> -- 
> http://www.livejournal.com/~pavelmachek