linux-kernel - Re: [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc19e30b-469d-6551-1c27-d51003afe90e@linuxfoundation.org>
Date:   Tue, 6 Apr 2021 15:19:08 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Brendan Higgins <brendanhiggins@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>
Cc:     David Gow <davidgow@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: fix -Wunused-function warning for
 __kunit_fail_current_test

On 4/6/21 2:50 PM, Brendan Higgins wrote:
> On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov <dlatypov@...gle.com> wrote:
>>
>> When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty
>> static function.
>>
>> But GCC complains about unused static functions, *unless* they're static inline.
>> So add inline to make GCC happy.
>>
>> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>
>> Fixes: 359a376081d4 ("kunit: support failure from dynamic analysis tools")
> 

Signed-off-by comes after Fixes. Also good to add Reported-by for 
Stephen acknowledging the reporter.

I will fix this up when I apply - for future reference.

> Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>
> 

thanks,
-- Shuah