linux-kernel - Re: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d91eb53-cde3-934c-a75f-833f98e6b156@kernel.org>
Date:   Tue, 6 Apr 2021 06:53:14 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Zucheng Zheng <zhengzucheng@...wei.com>, alcooperx@...il.com,
        gregkh@...uxfoundation.org
Cc:     linux-serial@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, hucool.lihua@...wei.com
Subject: Re: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root'
 static

On 01. 04. 21, 9:49, Zucheng Zheng wrote:
> symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
> so this commit marks it static.
> 
> Signed-off-by: Zucheng Zheng <zhengzucheng@...wei.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index 63883185fccd..ebba7f2e960c 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -239,7 +239,7 @@ struct brcmuart_priv {
>   	u32		rx_abort;
>   };
>   
> -struct dentry *brcmuart_debugfs_root;
> +static struct dentry *brcmuart_debugfs_root;
>   
>   /*
>    * Register access routines
> 


-- 
js