linux-kernel - Re: [PATCH] integrity/ima: Add declarations to init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bb74c3e-c91c-f070-7f8b-907b148cb958@gmail.com>
Date:   Tue, 6 Apr 2021 14:24:33 +0800
From:   Jiele Zhao <unclexiaole@...il.com>
To:     Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, james Morris <jmorris@...ei.org>
Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void
 arguments.

Hi Mimi,

Please see if this is a useful suggestion.

On 2021/4/6 10:38, James Morris wrote:
> On Tue, 6 Apr 2021, Jiele Zhao wrote:
>
>> Ping.
> Mimi Zohar is the maintainer for this code.
>
>> On 2021/3/23 9:33, Jiele Zhao wrote:
>>> init_once is a callback to kmem_cache_create. The parameter
>>> type of this function is void *, so it's better to give a
>>> explicit cast here.
>>>
>>> Signed-off-by: Jiele Zhao <unclexiaole@...il.com>
>>> ---
>>>    security/integrity/iint.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
>>> index 1d20003243c3..5f3f2de997e1 100644
>>> --- a/security/integrity/iint.c
>>> +++ b/security/integrity/iint.c
>>> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>>>    
>>>    static void init_once(void *foo)
>>>    {
>>> -	struct integrity_iint_cache *iint = foo;
>>> +	struct integrity_iint_cache *iint = (struct integrity_iint_cache
>>> *)foo;
>>>    
>>>     memset(iint, 0, sizeof(*iint));
>>>     iint->ima_file_status = INTEGRITY_UNKNOWN;