linux-kernel - Re: [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration

Open Source and information security mailing list archives

Message-ID: <ccba7901-676f-e8c5-2085-0f8f9d505754@microchip.com>
Date:   Tue, 6 Apr 2021 07:00:25 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <wanjiabing@...o.com>, <richard@....at>,
        <miquel.raynal@...tlin.com>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC:     <kael_w@...h.net>
Subject: Re: [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration

On 4/6/21 9:37 AM, Wan Jiabing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> struct ubi_wl_entry is defined at 178th line.
> The declaration here is unnecessary. Remove it.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

the subject of the patch should start with "ubi:", thus
"ubi: Remove unnecessary struct declaration"

with that:
Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> ---
>  drivers/mtd/ubi/ubi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
> index c2da77163f94..7c083ad58274 100644
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -388,8 +388,6 @@ struct ubi_volume_desc {
>         int mode;
>  };
> 
> -struct ubi_wl_entry;
> -
>  /**
>   * struct ubi_debug_info - debugging information for an UBI device.
>   *
> --
> 2.25.1
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives