linux-kernel - Re: [PATCH] gpio: gpio-it87: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210406083549.GR25703@kw.sim.vm.gnt>
Date:   Tue, 6 Apr 2021 10:35:49 +0200
From:   Simon Guinot <simon.guinot@...uanux.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: gpio-it87: remove unused code

On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: Simon Guinot <simon.guinot@...uanux.org>

> ---
>  drivers/gpio/gpio-it87.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
> index 8f1be34..f332341 100644
> --- a/drivers/gpio/gpio-it87.c
> +++ b/drivers/gpio/gpio-it87.c
> @@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
>  	return val;
>  }
>  
> -static inline void superio_outw(int val, int reg)
> -{
> -	outb(reg++, REG);
> -	outb(val >> 8, VAL);
> -	outb(reg, REG);
> -	outb(val, VAL);
> -}
> -
>  static inline void superio_set_mask(int mask, int reg)
>  {
>  	u8 curr_val = superio_inb(reg);
> -- 
> 1.8.3.1

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)