linux-kernel - Re: [PATCH] ecc: delete a useless function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e272e6e-6cb0-2c03-86c3-08d54690c97e@huawei.com>
Date:   Tue, 6 Apr 2021 09:12:40 +0800
From:   yumeng <yumeng18@...wei.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>
CC:     <linux-crypto@...r.kernel.org>, <wangzhou1@...ilicon.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ecc: delete a useless function declaration



在 2021/4/2 18:34, Christophe Leroy 写道:
> 
> 
> Le 02/04/2021 à 11:55, Meng Yu a écrit :
>> This function declaration has been added in 'ecc_curve.h',
>> delete it in 'crypto/ecc.h'.
>>
>> Fixes: 14bb76768275(crypto: ecc - expose ecc curves)
> 
> Fixes tag is wrong I think, should be 4e6602916bc6
> 

Yes, you are right, thank you.

>> Signed-off-by: Meng Yu <yumeng18@...wei.com>
>> ---
>>   crypto/ecc.h | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/crypto/ecc.h b/crypto/ecc.h
>> index 46aa9bc..a006132 100644
>> --- a/crypto/ecc.h
>> +++ b/crypto/ecc.h
>> @@ -56,14 +56,6 @@ static inline void ecc_swap_digits(const u64 *in, 
>> u64 *out, unsigned int ndigits
>>   }
>>   /**
>> - * ecc_get_curve()  - Get a curve given its curve_id
>> - * @curve_id:  Id of the curve
>> - *
>> - * Returns pointer to the curve data, NULL if curve is not available
>> - */
>> -const struct ecc_curve *ecc_get_curve(unsigned int curve_id);
>> -
>> -/**
>>    * ecc_is_key_valid() - Validate a given ECDH private key
>>    *
>>    * @curve_id:        id representing the curve to use
>>
> .