linux-kernel - Re: gemini: sl3516: Mainlining of NS 2502

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGwkr0qbYqR02Yyh@Red>
Date:   Tue, 6 Apr 2021 11:06:55 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     linus.walleij@...aro.org, ulli.kroll@...glemail.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: gemini: sl3516: Mainlining of NS 2502

Le Mon, Apr 05, 2021 at 10:36:32PM +0200, Andrew Lunn a écrit :
> On Mon, Apr 05, 2021 at 08:39:54PM +0200, Corentin Labbe wrote:
[ ... ]
> > libphy: Fixed MDIO Bus: probed
> > mdio-gpio ethernet-phy: failed to get alias id
> 
> That does not look too good. But it is just a warning.
> 
>         if (pdev->dev.of_node) {
>                 bus_id = of_alias_get_id(pdev->dev.of_node, "mdio-gpio");
>                 if (bus_id < 0) {
>                         dev_warn(&pdev->dev, "failed to get alias id\n");
>                         bus_id = 0;
>                 }
> 
> If you look at the example in the documentation, it has
> 
> aliases {
>         mdio-gpio0 = &mdio0;
> };
> 
> If you add that, i guess this will go away.
>   

Hello

Yes it go away with this

> > gemini-ethernet-port 6000c000.ethernet-port: probe 6000c000.ethernet-port ID 1
> > gemini-ethernet-port 6000c000.ethernet-port: using a random ethernet address
> > gemini-ethernet-port 6000c000.ethernet-port (unnamed net_device) (uninitialized): PHY init failed
> 
> And now it seems to of all gone horribly wrong :-(
> 
> This is the second Ethernet interface, the one you have commented as 
> 
> /* Not used in this platform */
> 
> I _think_ you just need to delete the entry, otherwise it tried to
> probe it. And then that probe fails, it looks like it also fails the
> working interface :-(

Deleting the entry did no change. It still try to probe it.
I will try to delete second interface in gemini.dtsi just in case...


> > # udhcpc -i eth0
> > udhcpc: started, v1.33.0
> > udhcpc: socket: Address family not supported by protocol
> 
> That suggests the kernel you have build does not have PF_PACKET.
> Enable CONFIG_PACKET_DIAG.

Yes adding it fixed this error message.

Thanks