linux-kernel - Re: [PATCH v3 13/25] x86/sgx: Add helpers to expose ECREATE and EINIT to KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210406214152.8c4d40679bd6a5e9b632637f@intel.com>
Date:   Tue, 6 Apr 2021 21:41:52 +1200
From:   Kai Huang <kai.huang@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     kvm@...r.kernel.org, linux-sgx@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, seanjc@...gle.com, jarkko@...nel.org,
        luto@...nel.org, dave.hansen@...el.com, rick.p.edgecombe@...el.com,
        haitao.huang@...el.com, pbonzini@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com
Subject: Re: [PATCH v3 13/25] x86/sgx: Add helpers to expose ECREATE and
 EINIT to KVM

On Tue, 6 Apr 2021 11:32:11 +0200 Borislav Petkov wrote:
> On Tue, Apr 06, 2021 at 09:24:24PM +1200, Kai Huang wrote:
> > Such invalid input has already been handled in handle_encls_xx() before calling
> > the two helpers in this patch. KVM returns to Qemu and let it decide whether to
> > kill or not. The access_ok()s here are trying to catch KVM bug.
> 
> Whatever they try to do, you cannot continue creating an enclave using
> invalid input, no matter whether you've warned or not. People do not
> stare at dmesg all the time.
> 
> > If so we'd better inject an exception to guest (and return 1) in KVM so guest
> > can continue to run. Otherwise basically KVM will return to Qemu and let it
> > decide (and basically it will kill guest).
> >
> > I think killing guest is also OK. KVM part patches needs to be updated, though,
> > anyway.
> 
> Ok, I'll make the changes and you can redo the KVM rest ontop.
> 

Thank you!