linux-kernel - Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7706d59fe7120106e4695fd83da5b089d5a36d87.camel@fi.rohmeurope.com>
Date:   Tue, 06 Apr 2021 13:57:19 +0300
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-power@...rohmeurope.com, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 3/7] regulator: IRQ based event/error notification
 helpers


On Tue, 2021-04-06 at 18:27 +0800, kernel test robot wrote:
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/kernel.h:16,
>                     from arch/x86/include/asm/percpu.h:27,
>                     from arch/x86/include/asm/current.h:6,
>                     from include/linux/sched.h:12,
>                     from include/linux/ratelimit.h:6,
>                     from include/linux/dev_printk.h:16,
>                     from include/linux/device.h:15,
>                     from drivers/regulator/irq_helpers.c:10:
>    drivers/regulator/irq_helpers.c: In function 'die_loudly':
> > > drivers/regulator/irq_helpers.c:46:11: error: expected ')' before
> > > 'msg'
>       46 |  pr_emerg(msg);
>          |           ^~~
>    include/linux/printk.h:301:21: note: in definition of macro
> 'pr_fmt'
>      301 | #define pr_fmt(fmt) fmt
>          |                     ^~~
>    drivers/regulator/irq_helpers.c:46:2: note: in expansion of macro
> 'pr_emerg'
>       46 |  pr_emerg(msg);
>          |  ^~~~~~~~

Ouch. Feeling stupid now.
I am sorry for the hassle folks. I'll fix this ASAP and resend.

> 
> vim +46 drivers/regulator/irq_helpers.c
> 
>     43	
>     44	static void die_loudly(const char *msg)
>     45	{
>   > 46		pr_emerg(msg);
>     47		BUG();
>     48	}
>     49	

Best Regards
	Matti Vaittinen