linux-kernel - Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHUa44HDrHP6-z=FRkNJtkSe8cVJY-acPDK_r7QrO5QgPwo+iA@mail.gmail.com>
Date:   Tue, 6 Apr 2021 14:30:30 +0200
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Heiko Thiery <heiko.thiery@...il.com>
Cc:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Guenter Roeck <linux@...ck-us.net>,
        OP-TEE TrustedFirmware <op-tee@...ts.trustedfirmware.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH] tee: optee: fix build error caused by recent optee
 tracepoints feature

Hi Heiko,

[+Arnd]

On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery <heiko.thiery@...il.com> wrote:
>
> Hi Jens,
>
> Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander
> <jens.wiklander@...aro.org>:
> >
> > On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> > > If build kernel without "O=dir", below error will be seen:
> > >
> > > In file included from drivers/tee/optee/optee_trace.h:67,
> > >                  from drivers/tee/optee/call.c:18:
> > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> > >    95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > >       |                                          ^
> > > compilation terminated.
> > >
> > > Fix it by adding below line to Makefile:
> > > CFLAGS_call.o := -I$(src)
> > >
> > > Tested with and without "O=dir", both can build successfully.
> > >
> > > Reported-by: Guenter Roeck <linux@...ck-us.net>
> > > Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> >
> > I've picked up this.
>
> For what tree did you pick this? I still see this build failure on the
> latest next tree (next-20210401).

The next tree hasn't been updated since 1th of April so it's not
unexpected. The fix is supposed to be on its way to
https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drivers
, I can't see it there yet though.

Cheers,
Jens