linux-kernel - Re: [PATCH v3 0/4] MIPS: Remove get_fs/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210406130133.GB9505@alpha.franken.de>
Date:   Tue, 6 Apr 2021 15:01:33 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Christoph Hellwig <hch@....de>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/4] MIPS: Remove get_fs/set_fs

On Tue, Apr 06, 2021 at 09:24:43AM +0200, Christoph Hellwig wrote:
> Btw, there is a bunch of cleanups that would fit in nicely on top of
> this:
> 
>  - remove the unused __invoke_copy_from function

I've removed in the last patch before applying to mips-next.

>  - fold __get_user_check into get_user as it is the only caller
>  - fold __get_user_nocheck into __get_user as it is the only caller
>  - fold __put_user_check into put_user as it is the only caller
>  - fold __put_user_nocheck into __put_user as it is the only caller
>  - implement get_user in terms of __get_user to document the difference
>    better and to remove __get_user_common
>  - implement put_user in terms of __put_user to document the difference
>    better and to remove __get_user_common
>  - remove __put_user_unknown/__get_user_unknown and replace them with
>    BUILD_BUG_ON()

I'll prepare a follow-up patch. Thank you for your cleanup hints.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]