linux-kernel - Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c485429-62a4-608f-6600-4e1f6e88c4e0@xilinx.com>
Date:   Tue, 6 Apr 2021 16:11:30 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Piyush Mehta <piyush.mehta@...inx.com>, <axboe@...nel.dk>
CC:     <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <git@...inx.com>, <sgoud@...inx.com>, <michal.simek@...inx.com>
Subject: Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()

Hi Jens,

On 3/5/21 10:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.
> 
> Also, unify message format for similar error cases.
> 
> Signed-off-by: Piyush Mehta <piyush.mehta@...inx.com>
> Acked-by: Michal Simek <michal.simek@...inx.com>
> ---
> This patch is based on ahci-ceva patches:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=5542fabd9e07d6c49c07862e73070c325f93d390
> 
> Tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
> 
> Changes for V2:
> - Address review comment- remove curly brackets {}. 
> ---
>  drivers/ata/ahci_ceva.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
> index b980218..50b56cd 100644
> --- a/drivers/ata/ahci_ceva.c
> +++ b/drivers/ata/ahci_ceva.c
> @@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
>  
>  	cevapriv->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
>  								  NULL);
> -	if (IS_ERR(cevapriv->rst)) {
> -		if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
> -			dev_err(&pdev->dev, "failed to get reset: %ld\n",
> -				PTR_ERR(cevapriv->rst));
> -	}
> +	if (IS_ERR(cevapriv->rst))
> +		dev_err_probe(&pdev->dev, PTR_ERR(cevapriv->rst),
> +			      "failed to get reset\n");
>  
>  	hpriv = ahci_platform_get_resources(pdev, 0);
>  	if (IS_ERR(hpriv))
> 

Can you please apply this to your tree?

Thanks,
Michal