linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPj211s_MCJ6R+DgETqzj8pbzToZv=aYsDjT-c-HvLst+4nNOQ@mail.gmail.com>
Date:   Tue, 6 Apr 2021 16:22:27 +0200
From:   FMDF <fmdefrancesco@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     outreachy-kernel@...glegroups.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces
 around operators

On Tue, Apr 6, 2021 at 4:12 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Apr 06, 2021 at 03:01:38PM +0200, Fabio M. De Francesco wrote:
> > Added spaces around operators in file HalBtc8723b1Ant.c. Issue detected
> > by checkpatch.pl. Spaces are preferred to improve readibility.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> > ---
> >  .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c   | 98 +++++++++----------
> >  1 file changed, 49 insertions(+), 49 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> > index 3e794093092b..b2b872016e45 100644
> > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> > @@ -38,7 +38,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> >                       (pCoexSta->preBtRssiState == BTC_RSSI_STATE_LOW) ||
> >                       (pCoexSta->preBtRssiState == BTC_RSSI_STATE_STAY_LOW)
> >               ) {
> > -                     if (btRssi >= (rssiThresh+BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> > +                     if (btRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> >
> >                               btRssiState = BTC_RSSI_STATE_HIGH;
> >                               BTC_PRINT(
> > @@ -85,7 +85,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> >                       (pCoexSta->preBtRssiState == BTC_RSSI_STATE_LOW) ||
> >                       (pCoexSta->preBtRssiState == BTC_RSSI_STATE_STAY_LOW)
> >               ) {
> > -                     if (btRssi >= (rssiThresh+BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> > +                     if (btRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> >                               btRssiState = BTC_RSSI_STATE_MEDIUM;
> >                               BTC_PRINT(
> >                                       BTC_MSG_ALGORITHM,
> > @@ -104,7 +104,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> >                       (pCoexSta->preBtRssiState == BTC_RSSI_STATE_MEDIUM) ||
> >                       (pCoexSta->preBtRssiState == BTC_RSSI_STATE_STAY_MEDIUM)
> >               ) {
> > -                     if (btRssi >= (rssiThresh1+BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> > +                     if (btRssi >= (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_1ANT)) {
> >                               btRssiState = BTC_RSSI_STATE_HIGH;
> >                               BTC_PRINT(
> >                                       BTC_MSG_ALGORITHM,
> > @@ -353,11 +353,11 @@ static void halbtc8723b1ant_MonitorBtCtr(struct btc_coexist *pBtCoexist)
> >
> >       u4Tmp = pBtCoexist->fBtcRead4Byte(pBtCoexist, regHPTxRx);
> >       regHPTx = u4Tmp & bMaskLWord;
> > -     regHPRx = (u4Tmp & bMaskHWord)>>16;
> > +     regHPRx = (u4Tmp & bMaskHWord) >> 16;
> >
> >       u4Tmp = pBtCoexist->fBtcRead4Byte(pBtCoexist, regLPTxRx);
> >       regLPTx = u4Tmp & bMaskLWord;
> > -     regLPRx = (u4Tmp & bMaskHWord)>>16;
> > +     regLPRx = (u4Tmp & bMaskHWord) >> 16;
> >
> >       pCoexSta->highPriorityTx = regHPTx;
> >       pCoexSta->highPriorityRx = regHPRx;
> > @@ -1317,7 +1317,7 @@ static void halbtc8723b1ant_SetFwPstdma(
> >       pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_BL_WIFI_AP_MODE_ENABLE, &bApEnable);
> >
> >       if (bApEnable) {
> > -             if (byte1&BIT4 && !(byte1&BIT5)) {
> > +             if (byte1 & BIT4 && !(byte1 & BIT5)) {
> >                       BTC_PRINT(
> >                               BTC_MSG_INTERFACE,
> >                               INTF_NOTIFY,
> > @@ -1349,9 +1349,9 @@ static void halbtc8723b1ant_SetFwPstdma(
> >               (
> >                       "[BTCoex], PS-TDMA H2C cmd = 0x%x%08x\n",
> >                       H2C_Parameter[0],
> > -                     H2C_Parameter[1]<<24|
> > -                     H2C_Parameter[2]<<16|
> > -                     H2C_Parameter[3]<<8|
> > +                     H2C_Parameter[1] << 24 |
> > +                     H2C_Parameter[2] << 16 |
> > +                     H2C_Parameter[3]<< 8 |
>
> Why did you miss the space that is needed here too?

I really don't know why I overlooked these.

>
> Did you run this patch through checkpatch.pl?

Yes, I did it as I always do.

>
> Please do so.
>
> thanks,
>
> greg k-h

I am going to send a v2 as soon as possible.

Thanks for your review,

Fabio