linux-kernel - Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPj211u9MHgtjeZGUPsLxU3HkbJ8cr2EUL0v9HA7LE9-b1uUoA@mail.gmail.com>
Date:   Tue, 6 Apr 2021 16:34:02 +0200
From:   FMDF <fmdefrancesco@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     outreachy-kernel@...glegroups.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove
 camelcase in Hal8723BReg.h

On Tue, Apr 6, 2021 at 4:11 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Apr 06, 2021 at 03:05:56PM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
> > are not used anywhere else, therefore this patch does not break the driver.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
>
> If this is "v2", you need to put below the --- line what changed from
> v1.

It is a v2 only because you made me notice that I forgot to cc
linux-staging and linux-kernel.
So I sent it again, but probably I shouldn't have changed the version
number because nothing else had changed.

> Please fix up and send a v3.
>

No problem at all. I can explain in the patch v3 what I wrote above.
May you please confirm that a patch v3 is the correct solution even
when nothing changes in the code?

Thanks for your help,

Fabio

> thanks,
>
> greg k-h