linux-kernel - Re: [PATCH] ASoC: simple-card: fix possible uninitialized single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d27f9314-8848-987a-7588-a1454ecae4ad@nvidia.com>
Date:   Wed, 7 Apr 2021 19:31:51 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
CC:     Colin King <colin.king@...onical.com>
Subject: Re: [PATCH] ASoC: simple-card: fix possible uninitialized single_cpu
 local variable



On 4/7/2021 2:50 PM, Krzysztof Kozlowski wrote:
> The 'single_cpu' local variable is assigned by asoc_simple_parse_dai()
> and later used in a asoc_simple_canonicalize_cpu() call, assuming the
> entire function did not exit on errors.
>
> However the first function returns 0 if passed device_node is NULL,
> thus leaving the variable uninitialized and reporting success.
>
> Addresses-Coverity: Uninitialized scalar variable
> Fixes: 8f7f298a3337 ("ASoC: simple-card-utils: separate asoc_simple_card_parse_dai()")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>   sound/soc/generic/audio-graph-card.c | 2 +-
>   sound/soc/generic/simple-card.c      | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>

Acked-by: Sameer Pujar <spujar@...dia.com>