linux-kernel - Re: [PATCH] Staging: android: ashmem: Fixed a const coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG3GLQA1O3b0w0RY@kroah.com>
Date:   Wed, 7 Apr 2021 16:48:13 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Barney Goette <barneygoette@...il.com>
Cc:     arve@...roid.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH] Staging: android: ashmem: Fixed a const coding style
 issue

On Wed, Apr 07, 2021 at 09:35:02AM -0500, Barney Goette wrote:
> Fixed a coding style issue.
> Reported by checkpatch.
> 
> Signed-off-by: Barney Goette <barneygoette@...il.com>
> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index d66a64e42273..7854fd410efa 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	static const struct file_operations vmfile_fops;
>  	struct ashmem_area *asma = file->private_data;
>  	int ret = 0;
>  
> -- 
> 2.25.1

Why did you not test-build your patch before sending it out?

Always do so.

thanks,

greg k-h