linux-kernel - Re: [PATCH v4 09/16] KVM: x86/pmu: Add PEBS_DATA_CFG MSR emulation to support adaptive PEBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG3Sfy2T8tjqSgkp@hirez.programming.kicks-ass.net>
Date:   Wed, 7 Apr 2021 17:40:47 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Like Xu <like.xu@...ux.intel.com>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>, eranian@...gle.com,
        andi@...stfloor.org, kan.liang@...ux.intel.com,
        wei.w.wang@...el.com, Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        Luwei Kang <luwei.kang@...el.com>
Subject: Re: [PATCH v4 09/16] KVM: x86/pmu: Add PEBS_DATA_CFG MSR emulation
 to support adaptive PEBS

On Mon, Mar 29, 2021 at 01:41:30PM +0800, Like Xu wrote:
> @@ -3863,6 +3864,12 @@ static struct perf_guest_switch_msr *intel_guest_get_msrs(int *nr, void *data)
>  		arr[2].host = (unsigned long)ds;
>  		arr[2].guest = pmu->ds_area;

		*nr = 3;
>  
> +		if (baseline) {
> +			arr[3].msr = MSR_PEBS_DATA_CFG;
> +			arr[3].host = cpuc->pebs_data_cfg;
> +			arr[3].guest = pmu->pebs_data_cfg;

			*nr = 4;
> +		}
> +
>  		/*
>  		 * If PMU counter has PEBS enabled it is not enough to
>  		 * disable counter on a guest entry since PEBS memory
> @@ -3879,9 +3886,11 @@ static struct perf_guest_switch_msr *intel_guest_get_msrs(int *nr, void *data)
>  		else {
>  			arr[1].guest = arr[1].host;
>  			arr[2].guest = arr[2].host;
> +			if (baseline)
> +				arr[3].guest = arr[3].host;
>  		}
>  
> -		*nr = 3;
> +		*nr = baseline ? 4 : 3;

And you don't need yet another branch to determine a value you already
know.

>  	}