linux-kernel - Re: [PATCH] inotify: fix minmax.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210407160546.GA3271@quack2.suse.cz>
Date:   Wed, 7 Apr 2021 18:05:46 +0200
From:   Jan Kara <jack@...e.cz>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Jan Kara <jack@...e.cz>, Amir Goldstein <amir73il@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org, Denis Efremov <efremov@...ux.com>
Subject: Re: [PATCH] inotify: fix minmax.cocci warnings

On Tue 06-04-21 22:49:26, Julia Lawall wrote:
> From: kernel test robot <lkp@...el.com>
> 
> Opportunity for min().
> 
> Generated by: scripts/coccinelle/misc/minmax.cocci
> 
> Fixes: 8636e3295ce3 ("coccinelle: misc: add minmax script")
> CC: Denis Efremov <efremov@...ux.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
...
> --- a/fs/notify/inotify/inotify_user.c
> +++ b/fs/notify/inotify/inotify_user.c
> @@ -382,7 +382,7 @@ static int inotify_add_to_idr(struct idr
> 
>  	spin_unlock(idr_lock);
>  	idr_preload_end();
> -	return ret < 0 ? ret : 0;
> +	return min(ret, 0);
>  }

Honestly, while previous expression is a standard idiom for "if 'ret' holds
an error, return it", the new expression is harder to understand for me. So
I prefer to keep things as they are in this particular case...

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR