linux-kernel - Re: [RESEND 00/25] Rid W=1 warnings from HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 18:09:22 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Anssi Hannula <anssi.hannula@...il.com>,
        Bruno Prémont <bonbons@...ux-vserver.org>,
        Christian König <christian.koenig@....com>,
        Daniel Drubin <daniel.drubin@...el.com>,
        Dario Pagani <dario.pagani.146+linuxk@...il.com>,
        dri-devel@...ts.freedesktop.org,
        Henrik Rydberg <rydberg@...math.org>,
        Jiri Kosina <jikos@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Kim Kuparinen <kimi.h.kuparinen@...il.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        linaro-mm-sig@...ts.linaro.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        linux-media@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        Linux USB Mailing List <linux-usb@...r.kernel.org>,
        Lopez Casado <nlopezcasad@...itech.com>,
        "L. Vinyard, Jr" <rvinyard@...nmsu.edu>,
        Masaki Ota <masaki.ota@...alps.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        message to <vojtech@....cz>,
        Michael Haboustak <mike-@...ci.rr.com>,
        Rushikesh S Kadam <rushikesh.s.kadam@...el.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        Vojtech Pavlik <vojtech@...e.cz>,
        Zhang Lixu <lixu.zhang@...el.com>
Subject: Re: [RESEND 00/25] Rid W=1 warnings from HID

On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (25):
> >   HID: intel-ish-hid: Remove unused variable 'err'
> >   HID: ishtp-hid-client: Move variable to where it's actually used
> >   HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> >   HID: intel-ish: Supply some missing param descriptions
> >   HID: intel-ish: Fix a naming disparity and a formatting error
> >   HID: usbhid: Repair a formatting issue in a struct description
> >   HID: intel-ish-hid: Fix a little doc-rot
> >   HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> >   HID: hid-alps: Correct struct misnaming
> >   HID: intel-ish-hid: Fix potential copy/paste error
> >   HID: hid-core: Fix incorrect function name in header
> >   HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> >     header
> >   HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> >   HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> >   HID: hid-picolcd_core: Remove unused variable 'ret'
> >   HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> >     abuses
> >   HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> >   HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> >   HID: hid-uclogic-params: Ensure function names are present and correct
> >     in kernel-doc headers
> >   HID: hid-sensor-custom: Remove unused variable 'ret'
> >   HID: wacom_sys: Demote kernel-doc abuse
> >   HID: hid-sensor-hub: Remove unused struct member 'quirks'
> >   HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> >     definition
> >   HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> >   HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
>
> These have been on the list for a couple of weeks now.
>
> Is there anything I can do to help expedite their merge?
>
> I'm concerned since -rc6 has just been released.

Sorry for the delay.

I am currently queuing them locally and running a few tests on them. I
don't expect anything to happen, but better be safe than anything.

FWIW, I am splitting the series in 3:
- 11 patches for intel ish are going to be queued in for-5.13/intel-ish
- the thrustmaster one in for-5.13/thrustmaster
- the rest (13 patches) will be sent in for-5.13/warnings.

Cheers,
Benjamin