linux-kernel - [PATCH] clk: fix for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2104072100410.11549@hadrien>
Date:   Wed, 7 Apr 2021 21:02:32 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Liam Beguin <liambeguin@...il.com>, mturquette@...libre.com,
        sboyd@...nel.org
cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        kbuild-all@...ts.01.org
Subject: [PATCH] clk: fix for_each_child.cocci warnings

From: kernel test robot <lkp@...el.com>

For_each_child_of_node should have of_node_put() before goto.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Liam Beguin <lvb@...hos.com>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
---

url:    https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base:   f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago

 clk-lmk04832.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
 		if (ret) {
 			dev_err(lmk->dev, "missing reg property in child: %s\n",
 				child->full_name);
+			of_node_put(child);
 			goto err_disable_oscin;
 		}