linux-kernel - Re: [PATCH] liquidio: Fix unintented sign extension of a left shift of a u16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161783341195.5631.6736576843347914096.git-patchwork-notify@kernel.org>
Date:   Wed, 07 Apr 2021 22:10:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Colin King <colin.king@...onical.com>
Cc:     dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        davem@...emloft.net, kuba@...nel.org,
        rvatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] liquidio: Fix unintented sign extension of a left shift of a
 u16

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed,  7 Apr 2021 11:12:48 +0100 you wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port
> (a u16) left 24 places. There are two subtle issues here, first the
> shift gets promoted to an signed int and then sign extended to a u64.
> If oct->pcie_port is 0x80 or more then the upper bits get sign extended
> to 1. Secondly shfiting a u16 24 bits will lead to an overflow so it
> needs to be cast to a u64 for all the bits to not overflow.
> 
> [...]

Here is the summary with links:
  - liquidio: Fix unintented sign extension of a left shift of a u16
    https://git.kernel.org/netdev/net-next/c/298b58f00c0f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html