linux-kernel - Re: [PATCH] ubifs: fix read fail but return ok

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvwer-w7ngekB_4rtBLWrr0KrwqLjavJd3ZTR8Xh5f_Y3A@mail.gmail.com>
Date:   Thu, 8 Apr 2021 00:11:19 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     wangfangpeng <wangfangpeng1@...wei.com>
Cc:     Richard Weinberger <richard@....at>,
        Adrian Hunter <ext-adrian.hunter@...ia.com>,
        Artem Bityutskiy <Artem.Bityutskiy@...ia.com>,
        linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>,
        Xiaoming Ni <nixiaoming@...wei.com>, zengweilin@...wei.com,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] ubifs: fix read fail but return ok

On Wed, Mar 31, 2021 at 8:29 AM wangfangpeng <wangfangpeng1@...wei.com> wrote:
> do_readpage() may return err, but ubifs_readpage() always return ok.
> The vfs will ignore the err happen in ubifs.

Are you sure about that?
In case of an error UBIFS sets the error flag of the page and does not
mark it as uptodate,
so vfs will emit -EIO. At least this is the theory. :-)

-- 
Thanks,
//richard