linux-kernel - Re: [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210407225627.GA860@kunai>
Date:   Thu, 8 Apr 2021 00:56:27 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Yicong Yang <yangyicong@...ilicon.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-i2c@...r.kernel.org, Sergey.Semin@...kalelectronics.ru,
        linux-kernel@...r.kernel.org, digetx@...il.com, treding@...dia.com,
        jarkko.nikula@...ux.intel.com, rmk+kernel@...linux.org.uk,
        song.bao.hua@...ilicon.com, john.garry@...wei.com,
        mika.westerberg@...ux.intel.com, prime.zeng@...wei.com,
        linuxarm@...wei.com
Subject: Re: [PATCH v6 2/5] i2c: core: add api to provide frequency mode
 strings


> > I guess exporting will save few dozens of bytes if the function is used more
> > than once. (All strings will be duplicated or multiplied in that case)
> > 
> 
> yes, that's one concern. since we don't need this to perform fast, an inline
> one maybe unnecessary.

Exactly. I also don't see an advantage of the function being inline. But
potential disadvantage, even if just small memory overhead. So, I'd
still rather see it as a core function.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)