[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3d840334-2c26-5748-8370-54cef6262e02@metafoo.de>
Date: Wed, 7 Apr 2021 06:56:42 +0200
From: Lars-Peter Clausen <lars@...afoo.de>
To: Puranjay Mohan <puranjay12@...il.com>,
alexandru.ardelean@...log.com, jic23@...nel.org,
devicetree@...r.kernel.org, knaack.h@....de,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
andy.shevchenko@...il.com
Subject: Re: [PATCH v3 2/2] iio: temperature: add driver support for ti tmp117
On 4/6/21 8:28 PM, Puranjay Mohan wrote:
> +
> +static int tmp117_write_raw(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *channel, int val,
> + int val2, long mask)
> +{
> + struct tmp117_data *data = iio_priv(indio_dev);
> + s16 off;
> +
> + switch (mask) {
> + case IIO_CHAN_INFO_CALIBBIAS:
> + off = clamp(val, -32768, 32767);
> + if (off == data->calibbias)
data->calibbias is only set in probe() and always 0. I'm not sure we
need to cache the value. Reading it back from the device seems fine.
> + return 0;
> + return i2c_smbus_write_word_swapped(data->client,
> + TMP117_REG_TEMP_OFFSET, off);
> +
> + default:
> + return -EINVAL;
> + }
> +}
> +
Powered by blists - more mailing lists