linux-kernel - Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9bd5abf-0293-6155-dee0-20199fed1fc0@huawei.com>
Date:   Wed, 7 Apr 2021 15:50:19 +0800
From:   "zhangjianhua (E)" <zhangjianhua18@...wei.com>
To:     Robert Foss <robert.foss@...aro.org>
CC:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        "Jernej Skrabec" <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        "Daniel Vetter" <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        <johnny.chenyi@...wei.com>, <heying24@...wei.com>
Subject: Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select
 GPIOLIB

Hi Robert

Yes, you are right, there are many files reference 
gpiod_set_value_cansleep() and

devm_gpiod_get_optional(). How about add config dependencies for all 
releated

configs or only add config dependencies for the top level config?


Best regards

Zhang Jianhua

在 2021/4/6 18:21, Robert Foss 写道:
> Hey Zhang
>
> On Tue, 6 Apr 2021 at 11:07, Zhang Jianhua <zhangjianhua18@...wei.com> wrote:
>> If CONFIG_DRM_LONTIUM_LT8912B=y, the following errors will be seen while
>> compiling lontium-lt8912b.c
>>
>> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function
>> ‘lt8912_hard_power_on’:
>> drivers/gpu/drm/bridge/lontium-lt8912b.c:252:2: error: implicit
>> declaration of function ‘gpiod_set_value_cansleep’; did you mean
>> ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
>>    gpiod_set_value_cansleep(lt->gp_reset, 0);
>>    ^~~~~~~~~~~~~~~~~~~~~~~~
>>    gpio_set_value_cansleep
>> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function ‘lt8912_parse_dt’:
>> drivers/gpu/drm/bridge/lontium-lt8912b.c:628:13: error: implicit
>> declaration of function ‘devm_gpiod_get_optional’; did you mean
>> ‘devm_gpio_request_one’? [-Werror=implicit-function-declaration]
>>    gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>>               ^~~~~~~~~~~~~~~~~~~~~~~
>>               devm_gpio_request_one
>> drivers/gpu/drm/bridge/lontium-lt8912b.c:628:51: error: ‘GPIOD_OUT_HIGH’
>> undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’?
>>    gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>>                                                     ^~~~~~~~~~~~~~
>>                                                     GPIOF_INIT_HIGH
>>
>> Signed-off-by: Zhang Jianhua <zhangjianhua18@...wei.com>
>> ---
>>   drivers/gpu/drm/bridge/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>> index dba62f92d051..caa9658ec933 100644
>> --- a/drivers/gpu/drm/bridge/Kconfig
>> +++ b/drivers/gpu/drm/bridge/Kconfig
>> @@ -67,6 +67,7 @@ config DRM_LONTIUM_LT8912B
>>          select DRM_PANEL_BRIDGE
>>          select DRM_KMS_HELPER
>>          select REGMAP_I2C
>> +       select GPIOLIB
> This appears like the right fix for this problem. However, a number of
> drm/bridge drivers seem to call both gpio_set_value_cansleep() and
> devm_gpiod_get_optional() without having the GPIOLIB kconfig option
> selected so this can't be a new issue. Maybe some more investigation
> is in order.
> .