linux-kernel - Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 10:05:28 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mitali Borkar <mitaliborkar810@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com, mitali_s@...iitr.ac.in
Subject: Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h

On Wed, Apr 07, 2021 at 01:27:29PM +0530, Mitali Borkar wrote:
> Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter
> Reported by checkpatch.
> 
> Signed-off-by: Mitali Borkar <mitaliborkar810@...mple.com>
> ---
>  drivers/staging/rtl8712/xmit_osdep.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/xmit_osdep.h b/drivers/staging/rtl8712/xmit_osdep.h
> index b76021b568f8..7ad2ac6f5ff0 100644
> --- a/drivers/staging/rtl8712/xmit_osdep.h
> +++ b/drivers/staging/rtl8712/xmit_osdep.h
> @@ -35,7 +35,7 @@ struct xmit_frame;
>  struct xmit_buf;
>  
>  int r8712_xmit_entry(_pkt *pkt, struct  net_device *pnetdev);
> -void r8712_SetFilter(struct work_struct *work);
> +void r8712_set_filter(struct work_struct *work);
>  int r8712_xmit_resource_alloc(struct _adapter *padapter,
>  			      struct xmit_buf *pxmitbuf);
>  void r8712_xmit_resource_free(struct _adapter *padapter,
> -- 
> 2.30.2
> 
> 

Did you try test-building your change?  Always do so :(