linux-kernel - Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c64a396-05ca-d19f-04ca-a3770e82c009@hisilicon.com>
Date:   Wed, 7 Apr 2021 16:18:37 +0800
From:   Yicong Yang <yangyicong@...ilicon.com>
To:     Wolfram Sang <wsa@...nel.org>, <andriy.shevchenko@...ux.intel.com>,
        <linux-i2c@...r.kernel.org>, <Sergey.Semin@...kalelectronics.ru>,
        <linux-kernel@...r.kernel.org>, <digetx@...il.com>,
        <treding@...dia.com>, <jarkko.nikula@...ux.intel.com>,
        <rmk+kernel@...linux.org.uk>, <song.bao.hua@...ilicon.com>,
        <john.garry@...wei.com>, <mika.westerberg@...ux.intel.com>,
        <prime.zeng@...wei.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

On 2021/4/7 4:02, Wolfram Sang wrote:
> 
> Only super minor stuff. Thanks to all the contributors and reviewers!
> 
>> +#define HZ_PER_KHZ	1000
> 
> KHZ_PER_HZ?

that doesn't match what we want. we want the count of HZs per one KHZ.

> 
>> +	ret = devm_i2c_add_adapter(dev, adapter);
>> +	if (ret) {
>> +		dev_err(dev, "failed to add i2c adapter, ret = %d\n", ret);
> 
> No need to print that. The core prints messages on failures.
> 

i check the code and find a little difference. the print in the core doesn't
have the device prefix so it may not tell us which device's registeration fails.
but considering we have device name embedded in the adapter name for this
driver, it's ok to remove this message.