linux-kernel - Re: [PATCH v3 2/4] crypto: support rsa-pss encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202104071609.Dx9pPd4S-lkp@intel.com>
Date:   Wed, 7 Apr 2021 16:40:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hongbo Li <herbert.tencent@...il.com>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
        dhowells@...hat.com, zohar@...ux.ibm.com, jarkko@...nel.org,
        herberthbli@...cent.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org,
        Hongbo Li <herbert.tencent@...il.com>
Subject: Re: [PATCH v3 2/4] crypto: support rsa-pss encoding

Hi Hongbo,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cryptodev/master]
[also build test WARNING on crypto/master security/next-testing linus/master v5.12-rc6 next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hongbo-Li/crypto-add-rsa-pss-support-for-x509/20210407-115152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-randconfig-s021-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-279-g6d5d9b42-dirty
        # https://github.com/0day-ci/linux/commit/cd6d6b64f74124a91cb5f0e5d5485d8b159c0ff7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hongbo-Li/crypto-add-rsa-pss-support-for-x509/20210407-115152
        git checkout cd6d6b64f74124a91cb5f0e5d5485d8b159c0ff7
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16

vim +247 crypto/rsa_helper.c

   235	
   236	int rsa_get_pss_saltlen(void *context, size_t hdrlen, unsigned char tag,
   237				const void *value, size_t vlen)
   238	{
   239		struct rsa_pss_ctx *ctx = context;
   240	
   241		if (!value || vlen < 1 || vlen > 2)
   242			return -EINVAL;
   243	
   244		if (vlen == 1)
   245			ctx->salt_len = *(u8 *)value;
   246		else if (vlen == 2)
 > 247			ctx->salt_len = ntohs(*(u16 *)value);
   248	
   249		return 0;
   250	}
   251	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35310 bytes)