linux-kernel - Re: [PATCH] mfd: arizona: Fix rumtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 08:49:50 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
CC:     <kjlu@....edu>, Lee Jones <lee.jones@...aro.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: arizona: Fix rumtime PM imbalance on error

On Wed, Apr 07, 2021 at 01:11:49PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() will increase the rumtime PM counter
> even it returns an error. Thus a pairing decrement is needed
> to prevent refcount leak. Fix this by replacing this API with
> pm_runtime_resume_and_get(), which will not change the runtime
> PM counter on error.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Wow, did not realise that was how that worked. Thanks for fixing
up.

Thanks,
Charles