linux-kernel - Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove camelcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2654358.BPhQiNMsfF@localhost.localdomain>
Date:   Wed, 07 Apr 2021 11:30:48 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     gregkh@...uxfoundation.org, outreachy-kernel@...glegroups.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove camelcase

On Wednesday, April 7, 2021 11:17:52 AM CEST Fabio M. De Francesco wrote:
> Remove camelcase. Issue detected by checkpatch.pl. The symbols aren't
> used in other files, so this change doesn't break the driver's code.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> ---
> 
> This is a necessary v2 patch because v1 cannot anymore apply to the current staging/testing tree
> 
>  drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
> index b9aca99478db..616d20106392 100644
> --- a/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
> +++ b/drivers/staging/rtl8723bs/hal/Hal8723BReg.h
> @@ -112,7 +112,7 @@
>  #define REG_RSVD3_8723B					0x0168
>  #define REG_C2HEVT_MSG_NORMAL_8723B	0x01A0
>  #define REG_C2HEVT_CMD_SEQ_88XX		0x01A1
> -#define REG_C2hEVT_CMD_CONTENT_88XX	0x01A2
> +#define REG_C2HEVT_CMD_CONTENT_88XX	0x01A2
>  #define REG_C2HEVT_CMD_LEN_88XX		0x01AE
>  #define REG_C2HEVT_CLEAR_8723B			0x01AF
>  #define REG_MCUTST_1_8723B				0x01C0
> @@ -429,13 +429,13 @@
>  #define	IMR_RXFOVW_8723B		BIT8	/*  Receive FIFO Overflow */
>  
>  /* 2 ACMHWCTRL 0x05C0 */
> -#define	AcmHw_HwEn_8723B		BIT(0)
> -#define	AcmHw_VoqEn_8723B		BIT(1)
> -#define	AcmHw_ViqEn_8723B		BIT(2)
> -#define	AcmHw_BeqEn_8723B		BIT(3)
> -#define	AcmHw_VoqStatus_8723B		BIT(5)
> -#define	AcmHw_ViqStatus_8723B		BIT(6)
> -#define	AcmHw_BeqStatus_8723B		BIT(7)
> +#define	ACMHW_HWEN_8723B		BIT(0)
> +#define	ACMHW_VOQEN_8723B		BIT(1)
> +#define	ACMHW_VIQEN_8723B		BIT(2)
> +#define	ACMHW_BEQEN_8723B		BIT(3)
> +#define	ACMHW_VOQSTATUS_8723B		BIT(5)
> +#define	ACMHW_VIQSTATUS_8723B		BIT(6)
> +#define	ACMHW_BEQSTATUS_8723B		BIT(7)
>  
>  /*        8195 (RCR) Receive Configuration Register	(Offset 0x608, 32 bits) */
>  #define	RCR_TCPOFLD_EN			BIT25	/*  Enable TCP checksum offload */
> 
I'm sorry I put the wrong patch version number in the subject and in the body.
Please diregard this patch. I'm about to send v4.

Thanks,

Fabio